Assistant dialog papercuts#559
Conversation
marcoambrosini
force-pushed
the
fix/534-assistant-dialog-papercuts
branch
from
c4aae95 to
075ad5a
Compare
marcoambrosini
added
bug
marcoambrosini
requested review from
Jana702 and
janepie
and removed request for
Jana702
marcoambrosini
force-pushed
the
fix/534-assistant-dialog-papercuts
branch
2 times, most recently
from
5acd18e to
57dc2b8
Compare
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
The button to toggle the left navigation sidebar disappears when the screen is narrow so it's impossible to navigate the task history (or the chat conversation list). Is it intentional?
Otherwise lgtm 👍
marcoambrosini
force-pushed
the
fix/534-assistant-dialog-papercuts
branch
from
eabb23d to
9bbff61
Compare
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
marcoambrosini
force-pushed
the
fix/534-assistant-dialog-papercuts
branch
from
9bbff61 to
777def4
Compare
|
Thanks for the review @julien-nc
This was actually a bug caused by my css approach. I reworked this a bit and now using a bit of a hack to toggle the navigation open and close. We cannot use the event bus because that would also affect the navigation of the app in the background. So using el.click() 🙈 |
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Works well!
This introduces a small blocking issue though:
The .p-dialog-header height is now too smal, it does not cover the space taken by its child elements. Not sure which change introduced that.
| }, | ||
| setup() { | ||
| return { isSmallMobile: useIsSmallMobile() } | ||
| }, |
There was a problem hiding this comment.
This block should go after the emits block.
3 participants
Fix: #534.
min(1220px, 90vw)Before
Screen.Recording.2026-05-27.at.16.25.10.mov
After
Screen.Recording.2026-05-27.at.16.23.47.mov